Ryan Barry has posted comments on this change. Change subject: Get serial console working on Fedora and add TUI configuration ......................................................................
Patch Set 33: >A couple of things that come to my mind: 1. Is the Bootloader class working >with efi and bios? On Fedora and EL? It would be nice if we can somehow add >doctests to prevent regressions, as we had many issues with this in the past. I've tested with EL6 and Fedora. Not EL7. But we're using GRUB/GRUB2, and the Bootloader class checks for both. This also works with EFI. Parsing GRUB works as a standard, and the code is loosely oriented around the same way we handle installing the bootloader in the first place. I'll look at how I can effectively sub out doctests for it when I get the chance. But these questions aren't really about this patch. >2. In the minimal size (80x24) the button wrapps the label into a second line. >This is not nice. Additionally: The button performs a system change, so IMO we >shoul dnot show it on the status page. But I couldnÄt find a page where it >would fit better. I can't think of a page where it would fit better either, hence its inclusion on the status page, I guess. -- To view, visit http://gerrit.ovirt.org/17982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id99623830b56b77815196c8b0d153c86d3704f00 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
