Fabian Deutsch has posted comments on this change. Change subject: Adding CI automation scripts to ovirt node ......................................................................
Patch Set 27: (1 comment) https://gerrit.ovirt.org/#/c/42549/27/automation/check-patch.sh File automation/check-patch.sh: Line 28: # generate new makefiles Line 29: ./autogen.sh Line 30: make distclean || clean_failed=true Line 31: Line 32: ./autogen.sh --with-image-minimizer Shouldn't we only run make check here? Line 33: if ! make publish ; then Line 34: die "Node building failed" Line 35: fi Line 36: -- To view, visit https://gerrit.ovirt.org/42549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44e9bdd6d3c6361da38d181d7417c9885535ddfc Gerrit-PatchSet: 27 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
