Fabian Deutsch has posted comments on this change. Change subject: Adding CI automation scripts to ovirt node ......................................................................
Patch Set 33: (1 comment) See the in-line comment, otherwise fine https://gerrit.ovirt.org/#/c/42549/33/automation/check-merged.sh File automation/check-merged.sh: Line 1: #!/bin/bash -xe Line 2: echo "check-merged.sh" Line 3: #this scripts build ovirt-node and ovirt-node-is projects Line 4: Line 5: source ./automation/build-node.sh Please do the build after the check-local Because for patches it is initially important that the check-local completes - and eventually also provides valuable feedback for fixing the sources. Line 6: Line 7: if ! make check-local ; then Line 8: die "Node check failed" -- To view, visit https://gerrit.ovirt.org/42549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44e9bdd6d3c6361da38d181d7417c9885535ddfc Gerrit-PatchSet: 33 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
