I somewhat agree with Bert here. On the other hand, we just outright block querystrings from having keys named hasOwnProperty, __defineGetter__, etc., and I believe we may do the same for http headers. We probably ought to make a decision and have them all work the same. I'd be tempted to maybe add some kind of "not instanceof Object object" goober and use for these cases.
On Fri, Jun 22, 2012 at 4:58 PM, Ben Noordhuis <[email protected]> wrote: > On Fri, Jun 22, 2012 at 7:22 PM, Bert Belder <[email protected]> wrote: >> >> >> On Friday, June 22, 2012 6:27:49 PM UTC+2, Ben Noordhuis wrote: >>> >>> `process.env` is not a real JS object. it's a stub for a chunk of C++ >>> code. But by all means file an issue if you feel strongly about this, >>> we can probably fix it. >> >> >> I don't agree. People shouldn't rely on prototype methods of objects that >> are used as hash tables. Same story for the http headers object, parsed >> querystring arguments etc. > > Apparently Bert feels strongly about this. :-) > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
