On Wed, Feb 6, 2013 at 4:04 PM, TJ <nod...@iam.tj> wrote:
> On 06/02/13 14:55, Ben Noordhuis wrote:
>> On Wed, Feb 6, 2013 at 2:52 PM, TJ <nod...@iam.tj> wrote:
>>> I needed the facility to build to an out-of-tree location rather than the 
>>> hard-code "out/" directory in the source tree.
>>>
>>> So far it works with all the test scenarios I've needed it for so I thought 
>>> I'd put it out for wider testing and feedback. I'm sure there are use-cases 
>>> and platform gotchas that I don't hit.
>>
>> Looks like an acceptable change to me.  Can you submit it as a pull request?
>>
> Thanks.
>
> I'd like it to get some exposure before it gets pulled. My Linux+GCC build 
> environment isn't going to stretch some of the other build platforms and 
> options and I've not needed to do install-target
> testing.
>
> If I get no issues reported in, say two weeks, I'll issue a pull request if 
> that is acceptable?

Sure.  Though the best way to get issues reported is to land it in
master.  :-)  Worst case, I revert it.

-- 
-- 
Job Board: http://jobs.nodejs.org/
Posting guidelines: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to nodejs+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to