I've triggered a bug in the test suite when working from the out-of-tree build 
directory.

The bug is in test/simple/test-fs-realpath.js:268:test_relative_input_cwd()

In particular the assumption that process.cwd() and common.tmpDir are directly 
related causes

 var entry = common.tmpDir.substr(entrydir.length + 1) + '/cycles/realpath-3a';

to break and cause an abort.

Since "entrydir.length + 1", when running out-of-tree, is unrelated, what ends 
up happening
is a random substr is chosen which will likely not be on a directory-separation 
border. This results
in an incomplete directory name.

This also exposes a greater issue that needs some thought from those that know 
the test suite.

When working from the out-of-tree build directory the common.tmpDir path points 
into the source
directory location whereas process.cwd() will be a descendant of the build 
directory.

There needs to be a consistent way to separate and reference paths for:

1. The current working directory (CWD)
2. The output directory common.tmpDir which is a descendant of CWD
3. The source directory containing the Javascript test files

-- 
-- 
Job Board: http://jobs.nodejs.org/
Posting guidelines: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to nodejs+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to