Another issue with using process.nextTick() is it ruins the stack trace (which 
might be fine or maybe even desirable in some cases, but isn't so great for 
error checking/handling).  That can be fixed by using bind(), but at that point 
we're adding a lot of cruft to the code IMO. (Related gist that shows stack 
traces: https://gist.github.com/BryanDonovan/6254656).

As a real-life example, I wrote an Elasticsearch client that checks for missing 
args in fashion I mentioned earlier in this thread (e.g., 
https://github.com/BryanDonovan/node-simple-elasticsearch/blob/master/lib/client.js#L94).
  Is that something I need to change?

Thanks,

Bryan


On Aug 20, 2013, at 10:47 AM, Bryan Donovan <[email protected]> wrote:

> I have been writing node.js client code for a couple of years now, and have 
> authored a couple open source libraries, but somehow I missed the memo 
> telling me that I'm supposed to wrap 'synchrounous' callbacks in 
> process.nextTick().  I kind-of understand why that is a best-practice, but 
> what I don't understand is what the drawback is if you don't do it.
> 
> For example, I write code like this all the time, and have never had a single 
> problem with it:
> 
> function getSomething(args, cb) {
>     if (!args) { return cb(new Error('args required')); }
>     if (!args.id) { return cb(new Error('args.id required')); }
> 
>     SomeDatabase.get({id: args.id}, cb);
> }
> 
> What are the potential issues with not wrapping those arg checks in 
> process.nextTick()?
> 
> 
> Thanks, 
> 
> Bryan
> 
> -- 
> -- 
> Job Board: http://jobs.nodejs.org/
> Posting guidelines: 
> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
> You received this message because you are subscribed to the Google
> Groups "nodejs" group.
> To post to this group, send email to [email protected]
> To unsubscribe from this group, send email to
> [email protected]
> For more options, visit this group at
> http://groups.google.com/group/nodejs?hl=en?hl=en
>  
> --- 
> You received this message because you are subscribed to a topic in the Google 
> Groups "nodejs" group.
> To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/nodejs/0TmVfX9z1R0/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to 
> [email protected].
> For more options, visit https://groups.google.com/groups/opt_out.

-- 
-- 
Job Board: http://jobs.nodejs.org/
Posting guidelines: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to