On Tue, Aug 5, 2014 at 11:35 AM, Tom Hughes <[email protected]> wrote: > So I've knocked up the attached patch which actually extends the existing > nodejs-node-lodash spec file using some lua magic to generate the separate > modules as well as the existing nodejs-lodash-node module.
Yeah this belongs in the SRPM the source code comes from, so this is fine. > The alternative is to create a separate srpm, but there isn't really a > source to base it on other than the list of modules to build? > > The package.json files it produces aren't quite the same as the published > ones for the modules. I assume the differences are changes made by npm when > publishing? I don't think npm changes anything when publishing. It does add a bunch of stuff to the JSON endpoints at https://registry.npmjs.org/ but AFAIK it leaves the package.json in the tarball alone. But `npm init` and related commands add some extra fields intended for humans that aren't really necessary for stuff like this. So they can probably be ignored. > Biggest issue is probably that the private flag is set, which > means the auto-provide doesn't happen and I have to add it manually instead. I guess it would be more correct to strip the _private field from the JSON, but honestly I don't see how it matters very much... > What do people think about this approach? Looks nice. I was having nightmares about texlive.spec but your lua magic here is much nicer and easier to see what's going on. Excellent work! Please commit. Thanks, -T.C. _______________________________________________ nodejs mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/nodejs
