On Sun, Sep 1, 2019 at 6:16 AM Tom Hughes <t...@compton.nu> wrote: > > On 30/08/2019 14:44, Ben Rosser wrote: > > On Fri, Aug 30, 2019 at 3:59 AM Tom Hughes <t...@compton.nu> wrote: > >> > >> On 29/08/2019 20:01, Ben Rosser wrote: > >> > >>> Hm, does it make sense then to have a compatibility package for lodash3? > >> > >> I think we may have to multiversion it yes. Been thinking that for > >> a while. > >> > >> I'll try and have a look at doing a lodash4 version of the spec > >> over the weekend... > > > > Great, thanks for looking into it! > > So I now have a working spec for v4 and having now refreshed > my memory of how it all works I think the issues may not be as > bad as I remembered. > > Anything which uses nodejs-lodash and loads the whole thing, or > a whole group, so things like: > > require("lodash") > require("lodash/array") > > should be fine, obviously modulo any changes to how the lodash > methods work or removal of old methods. > > So should anything which uses one of the split out single method > modules like nodejs-lodash-pad. > > Both nodejs-lodash-compat and nodejs-lodash-node go away but there > is appears to be nothing actually using them. > > The remaining issue is things using nodejs-lodash and loading an > individual method with something like: > > require("lodash/array/chunk") > > which would now need to change to: > > require("lodash/chunk") > > Given all this I'm kind of tempted to just go for it and do the > update and then fixup the dependants, which are far less than my > memory suggested, maybe because so many things have been retired > now. > > Tom
Hi Tom, I'm certainly in favor of going ahead with this, and no one seems to have objected (at least not on this list). Let me know if I can do something to help. Cheers, Ben _______________________________________________ nodejs mailing list -- nodejs@lists.fedoraproject.org To unsubscribe send an email to nodejs-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/nodejs@lists.fedoraproject.org