On 03/09/2020 16:41, Troy Dawson wrote:

> Any changes and/or improvements that people think should be made?

Well macros for all that boilerplate in the spec is an
obvious one.

Also making the script fetch the actual version being packaged 
rather than the latest version would be good. Something like:

VERSION="$(rpmspec --srpm --queryformat=%{VERSION} -q nodejs-${PACKAGE}.spec)"

and then:

npm pack ${PACKAGE}@${VERSION}

Tom

-- 
Tom Hughes ([email protected])
http://compton.nu/
_______________________________________________
nodejs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to