On Mon, Oct 20, 2025 at 2:58 AM Jan Stanek <[email protected]> wrote:
> > In order to create the node_module bundles, I need to have "husky" and > "playwright" installed. I think playwright is needed for tests, but let's > ignore that for a moment. > > There is the nodejs-packaging-bundler script (installed via rpm of the > same name) that should semi-automate creating the nodejs_module > tarballs for you. See the nodejs-packaging README [1] on how to use > it. > Right, I'm using that. But podman desktop's package.json needs husky in a "prepare" step, and playwright in a "postinstall" step. Both modules are listed as devDepedencies, but npm pack fails if they are not available in the user's PATH before running nodejs-packaging-bundler https://github.com/podman-desktop/podman-desktop/blob/main/package.json#L111-L112 > Is there a rule that would compel us to package the tools required to > generate the bundles? > > Generally speaking, that would be the preferred approach in Fedora. > OTOH, given that the nodejs ecosystem usually expects everything to be > bundled in local node_modules, and the permanent exception to bundling > nodejs rpms have, you can just bundle them with your app if you are > not too interested in also providing and maintaining them for others > to use. > Bundling them won't work because they're required to create the bundle. :)
-- _______________________________________________ nodejs mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
