On Tue, Nov 4, 2025 at 5:16 AM Gordon Messmer <[email protected]> wrote: > I've opened > https://src.fedoraproject.org/rpms/nodejs-packaging/pull-request/18 and could > use some feedback. podman-desktop requires pnpm to build, and I'm not sure > if it would be preferable to have one bundler script that can run whichever > tool is needed, or if it would be better to have separate scripts. I also > wanted to ask if npm should "--ignore-scripts" when building the node_modules > folders. I know that some source gathering scripts exclude specific scripts, > but it seems like any scripts should run in the build phase rather than when > gathering node_modules.
The script exists to make our work easier, so if you can extend it without it being too convoluted, I will likely accept the changes. Unfortunately here I suffer from not actually having any JS projects under my belt, nor really having to package anything that would require anything other than npm, so my insight is limited. So use your best judgement and we can discuss the particulars once I can give the PR a proper read over. Ditto for the `--ignore-scripts` – from the face value it seems reasonable, no idea how much this will break things. -- Jan Stanek Software Engineer Red Hat IM: @jstanek -- _______________________________________________ nodejs mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
