[
https://issues.apache.org/jira/browse/ACCUMULO-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807684#comment-13807684
]
Josh Elser commented on ACCUMULO-1773:
--------------------------------------
[~kturner], added some things. The only real change of note was adding a quick
short-circuit when we find a file that's part of a bulk-load instead of
continuing to scan through all candidates.
I added some TODOs in GCEnv#delete on the try/catch for AccumuloException,
TableNotFoundException, and AccumuloSecurityException. It seems like we would
want to pass an exception up. IOException? RuntimeException?
The rest was mostly writing down some javadoc/comments. Feel free to keep/chuck
whatever was right/wrong.
> Garbage collector may delete referenced files after upgrade
> -----------------------------------------------------------
>
> Key: ACCUMULO-1773
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1773
> Project: Accumulo
> Issue Type: Sub-task
> Components: master, tserver
> Reporter: Keith Turner
> Assignee: Keith Turner
> Priority: Blocker
> Fix For: 1.6.0
>
>
> Looking at the srouce code, it seems like the garbage collector uses a
> mixture of relative and absolute paths when determining what files to delete.
> I think if a deletion candidate is an absolute path and the reference is a
> relative path then it could delete the referenced file.
--
This message was sent by Atlassian JIRA
(v6.1#6144)