[
https://issues.apache.org/jira/browse/ACCUMULO-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898230#comment-13898230
]
Keith Turner commented on ACCUMULO-2345:
----------------------------------------
I think the current patch cleans up the code nicely and just needs a slight
tweak. Just change it to initially set Violations to null and later handle the
case of it being null. Leave the changes to the first if stmt as it is in the
patch. I am not sure why the throwable was kept and then later checked w/ an
else if. Moving that code into the catch looks so much nicer.
To make the code more concise, could possibly have a private static method that
does the null check, {{violations = addViolations(violations, violation)}}
> Improve ConstraintChecker.check
> -------------------------------
>
> Key: ACCUMULO-2345
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2345
> Project: Accumulo
> Issue Type: Improvement
> Components: tserver
> Affects Versions: 1.7.0
> Reporter: Vikram Srivastava
> Assignee: Vikram Srivastava
> Priority: Trivial
> Fix For: 1.7.0
>
> Attachments: ACCUMULO-2345.v1.patch.txt
>
>
> The if-else condition inside {{for}} loop can be merged with try-catch since
> {{throwable}} is not null only if code goes inside the catch section.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
