[ 
https://issues.apache.org/jira/browse/ACCUMULO-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089795#comment-15089795
 ] 

ASF GitHub Bot commented on ACCUMULO-4095:
------------------------------------------

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/63#issuecomment-170102128
  
    > I wish I could see the files side-by-side in GitHub to review, but the 
file was moved in addition to being updated, so GitHub is confused. :(
    
    Blarg. The crux of things is that the method `createFrameBuffer` exists on 
`SelectAcceptThread` *not* `THsHaServer` (or in its lineage). The easiest hack 
I saw was to inject our own custom `SelectAcceptThread`, akin to what we were 
doing with the `FrameBuffer`. Eric messed up the changes and used the 
`AsyncFrameBuffer` interface instead of the `FrameBuffer` class in his original 
commit too (we don't use the Async Processors -- our rpc system is blocking).
    
    I think that's the best synopsis of what's going on here. I would also be 
OK with throwing in the thrift warning. As always, we *never* want to 
willy-nilly update libthrift versions.


> ShellServerIT#listscans failing due to null client
> --------------------------------------------------
>
>                 Key: ACCUMULO-4095
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4095
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 1.8.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {noformat}
> root@miniInstance listscans> listscans
>  TABLET SERVER        | CLIENT               | AGE      | LAST     | STATE  | 
> TYPE  | USER    | TABLE   | COLUMNS   | AUTHORIZATIONS      | TABLET    | 
> SCAN ID    | ITERATORS            | ITERATOR OPTIONS
>   hw10447.local:53868 |                 null |      9ms |      9ms |RUNNING 
> |SINGLE |    root |listscans |        [] |                     |       2<< | 
> 4790077908898785386 
> |[SlowIterator=30,org.apache.accumulo.test.functional.SlowIterator] | 
> {SlowIterator={sleepTime=500}}
> {noformat}
> Note that the client column has a value of "null". This is causing the test 
> to fail. Seems to only be happening on master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to