[
https://issues.apache.org/jira/browse/ACCUMULO-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243069#comment-15243069
]
ASF GitHub Bot commented on ACCUMULO-4191:
------------------------------------------
Github user ShawnWalker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/94#discussion_r59887691
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
@@ -733,7 +733,7 @@ else if (Tables.getTableState(context.getInstance(),
table) == TableState.OFFLIN
void queueMutations(final MutationSet mutationsToSend) throws
InterruptedException {
if (null == mutationsToSend)
return;
- binningThreadPool.execute(new Runnable() {
+ binningThreadPool.execute(Trace.wrap(new Runnable() {
--- End diff --
Looking at `org.apache.htrace.wrappers.TraceRunnable`, it's not really
designed to be used as you're suggesting. One would hope to be able to write:
```java
threadPool.execute(new TraceRunnable() { ... })
```
But the best that `TraceRunnable` allows is:
```java
threadPool.execute(new TraceRunnable(new Runnable() {...}));
```
> Tracing on client can sometimes lose "sendMutations" events.
> ------------------------------------------------------------
>
> Key: ACCUMULO-4191
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4191
> Project: Accumulo
> Issue Type: Bug
> Reporter: Shawn Walker
> Assignee: Shawn Walker
> Priority: Minor
>
> In {{TabletServerBatchWriter.MutationWriter.queueMutations(...)}} (line 736),
> HTrace {{Span}}'s are not properly propagated across thread boundaries.
> Consequently, tracing doesn't propagate into
> {{TabletServerBatchWriter.SendTask.send(...)}}, and so the {{sendMutation}}
> event can fail to be logged.
> This can cause {{ShellServerIT.trace(...)}} to fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
