[
https://issues.apache.org/jira/browse/ACCUMULO-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243182#comment-15243182
]
ASF GitHub Bot commented on ACCUMULO-4191:
------------------------------------------
Github user madrob commented on the pull request:
https://github.com/apache/accumulo/pull/94#issuecomment-210531758
Might be better to wrap the whole pool instead of each individual runnable
using `tracer.newTraceExecutorService(...)`.
> Tracing on client can sometimes lose "sendMutations" events.
> ------------------------------------------------------------
>
> Key: ACCUMULO-4191
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4191
> Project: Accumulo
> Issue Type: Bug
> Reporter: Shawn Walker
> Assignee: Shawn Walker
> Priority: Minor
>
> In {{TabletServerBatchWriter.MutationWriter.queueMutations(...)}} (line 736),
> HTrace {{Span}}'s are not properly propagated across thread boundaries.
> Consequently, tracing doesn't propagate into
> {{TabletServerBatchWriter.SendTask.send(...)}}, and so the {{sendMutation}}
> event can fail to be logged.
> This can cause {{ShellServerIT.trace(...)}} to fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
