[
https://issues.apache.org/jira/browse/ACCUMULO-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860690#comment-15860690
]
Christopher Tubbs commented on ACCUMULO-4584:
---------------------------------------------
[~elserj], mind taking a look at this? If we can remove these checks, any ideas
on how to update the RpcWrapperTest to verify the correct behavior?
The question is: is it better to wrap exceptions from oneway methods with
TException like all the rest (effectively reverting ACCUMULO-4065) and have
thrift drop them, or is it better to use reflection to figure out which methods
are oneway and pass those through (keeping ACCUMULO-4065) unwrapped?
> Determine need for oneway method handling in RpcWrapper
> -------------------------------------------------------
>
> Key: ACCUMULO-4584
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4584
> Project: Accumulo
> Issue Type: Task
> Components: rpc
> Reporter: Christopher Tubbs
> Assignee: Christopher Tubbs
> Fix For: 2.0.0
>
>
> RpcWrapper has checks for oneway methods (from ACCUMULO-4065), but may no
> longer need it after upgrading to Thrift 0.10.0, due to the fix in THRIFT-3479
> Should determine whether these are still needed or can be removed.
> The current RpcWrapperTest fails if the checks are removed, but that test
> code may be assuming behavior in thrift, since it doesn't seem to actually
> use thrift code in the test itself.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
