[
https://issues.apache.org/jira/browse/ACCUMULO-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861871#comment-15861871
]
Christopher Tubbs commented on ACCUMULO-4584:
---------------------------------------------
Okay, so this is what I think we should do, based on IRC conversation with
[~elserj] and additional inspection of the code:
# Remove the checks in the wrapper for oneway methods, so we wrap all
RuntimeException with TException
# Rely on thrift 0.10.0 behavior to log and drop oneway exceptions
# Remove wrapping for Error (that's dangerous and unpredictable)
# Remove unnecessary reflection utils to inspect service for oneway methods and
simplify wrapper code
# Remove unnecessary and broken RpcWrapperTests
# Create simple IDL test case using our RpcWrapper and libthrift to verify
expected behavior for oneway and regular methods (might be separate issue) for
regression testing
# If future version of thrift incorporates wrapping of RuntimeException, we
delete all our RpcWrapper stuffs and push regression test case into thrift
itself
> Determine need for oneway method handling in RpcWrapper
> -------------------------------------------------------
>
> Key: ACCUMULO-4584
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4584
> Project: Accumulo
> Issue Type: Task
> Components: rpc
> Reporter: Christopher Tubbs
> Assignee: Christopher Tubbs
> Fix For: 2.0.0
>
>
> RpcWrapper has checks for oneway methods (from ACCUMULO-4065), but may no
> longer need it after upgrading to Thrift 0.10.0, due to the fix in THRIFT-3479
> Should determine whether these are still needed or can be removed.
> The current RpcWrapperTest fails if the checks are removed, but that test
> code may be assuming behavior in thrift, since it doesn't seem to actually
> use thrift code in the test itself.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
