[
https://issues.apache.org/jira/browse/ACCUMULO-4620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961712#comment-15961712
]
Christopher Tubbs commented on ACCUMULO-4620:
---------------------------------------------
To speak to some of the benefits, and from my perspective:
This is something I've wanted to happen for a *long* time, but never thought it
was worth the potential for disruption (particularly when we were using SVN).
However, over the last few years, we've switched to git and added a lot of new
modules, for the sake of modularity: separation of responsibilities between
components, distinguishing between client/server components, dependency
management/reduction, and general code organization. So many modules adds
clutter and makes it hard to navigate the source code a bit. In particular, it
makes it difficult to distinguish--at a glance--between maven modules and other
directories, like contrib and the root module's own src and target directories.
So, I'm glad Mike thought to pick this up (without me suggesting it... although
there were a few times I've wanted to create a JIRA or raise the discussion on
the lists). This is something Fluo did from the beginning, and I think it's
very convenient. Accumulo has a lot more modules than Fluo and could benefit
even more.
It's a very minor change, which can help new developers navigate the source
tree, with zero impact on users or the resulting build artifacts. This is
something which would have been very inconvenient in SVN, but something git can
handle quite easily.
If anything I would suggest keeping the server hierarchy instead of flattening
all the modules into a single directory (and maybe add more top-level
hierarchies underneath the modules directory), but even with the flattening, I
think it's still better than cluttering everything in the root. I actually wish
more maven projects would adopt this convention.
The benefits may be relatively minor, but so is the impact to the project. So I
think it's worth it.
> Consolidate all Maven modules into one directory
> ------------------------------------------------
>
> Key: ACCUMULO-4620
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4620
> Project: Accumulo
> Issue Type: Improvement
> Components: build
> Reporter: Mike Walch
> Assignee: Mike Walch
> Fix For: 1.7.4, 1.8.2, 2.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, Accumulo has most of its Maven modules residing in the root
> directory and some modules in a {{server}} directory. It would be great if
> all Accumulo modules were consolidate into a {{modules}} directory to put
> every module in one directory and reduce the number of directories in the
> root project directory. To simplify merges in the future, this should also be
> done for {{1.8}} and {{1.7}} branches in addition to {{master}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
