joshelser commented on issue #295: ACCUMULO-4699 Fixed queued work key in replication URL: https://github.com/apache/accumulo/pull/295#issuecomment-327250903 ```java Map<String,String> replicationForPeer = queuedWorkByPeerName.get(peerName); if (null == replicationForPeer) { replicationForPeer = new HashMap<>(); - queuedWorkByPeerName.put(sourceTableId, replicationForPeer); + queuedWorkByPeerName.put(peerName, replicationForPeer); } ``` I think it would be pretty easy to unit test `initializeQueuedWork()` -- `DistributedWorkQueueWorkAssignerHelper` already exists with helper methods to handle the serialization. You don't need to write some end-to-end case that uses a real Accumulo instance. You might have to mock out some more methods in SequentialWorkAssigner (e.g. `workQueue.getWorkQueued()`), but it strikes me as being straightforward. If it's not, please ask a more specific question about what still confuses you. > Sorry I don't understand the replication process well enough to write a test. I was more frustrated that I saw this was merged with my comment being ignored. It's fine if you don't know how to address a test (we all face this). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
