joshelser commented on issue #295: ACCUMULO-4699 Fixed queued work key in replication URL: https://github.com/apache/accumulo/pull/295#issuecomment-327307289 > That is my mistake. I took your comments as +0. Then I merged the PR without the intention of writing a test. Not an issue, that's why I dropped the ":\" in the first place and didn't leave any sort of flame ;). I thought it was a simple way to just grab your attention. The distinction between -0 and +0 is pretty vague and I'm not going to fault anyone for assuming the opposite. It really wasn't as big of an issue as it's blown up to be. > As far as the test goes, I appreciate your explanations but I don't think we need a test for this fix. It is not new code.. I'd disagree with you on the above point, but, I don't feel strongly enough to -1 your commit, so I'll (likely) think that I should write one myself for a few weeks until I forget about it :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
