keith-turner commented on a change in pull request #297: ACCUMULO-4702 Code fixes to work with Guava 23 URL: https://github.com/apache/accumulo/pull/297#discussion_r138375191
########## File path: core/src/main/java/org/apache/accumulo/core/util/HostAndPort.java ########## @@ -0,0 +1,262 @@ +/* + * Copyright (C) 2011 The Guava Authors + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except + * in compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.accumulo.core.util; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkState; + +import java.io.Serializable; + +import com.google.common.base.Strings; + +/** Review comment: I think it would be nice to add a comment somewhere in the javadoc stating which version of guava this was copied from and why... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
