keith-turner commented on a change in pull request #297: ACCUMULO-4702 Code 
fixes to work with Guava 23
URL: https://github.com/apache/accumulo/pull/297#discussion_r138397979
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/util/HostAndPort.java
 ##########
 @@ -22,6 +22,13 @@
 import com.google.common.base.Strings;
 
 /**
+ * This class was copied from Guava release 23.0 to replace the older Guava 14 
version that had been used in Accumulo.
+ * It was annotated as Beta by Google, therefore unstable to use in a core 
Accumulo library.  We learned this the hard
+ * way when Guava version 20 deprecated the getHostText method and then 
removed the method all together in version 22.
 
 Review comment:
   could reference the issue number
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to