keith-turner commented on a change in pull request #306: ACCUMULO-4170 Clarify ClientConfiguration javadocs URL: https://github.com/apache/accumulo/pull/306#discussion_r144360720
########## File path: core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java ########## @@ -41,7 +41,22 @@ /** * Contains a list of property keys recognized by the Accumulo client and convenience methods for setting them. - * + * <p> + * When loading a configuration file from the system, Accumulo uses the <em>ACCUMULO_CLIENT_CONF_PATH</em> environment variable, Review comment: > It can be moved back into the method call only if you think that would be more appropriate. Personally I would put the docs on the loadDefault method and then any constuctors that call load default I would state in the constuctors javadoc that it follows the search behavior described in loadDefatult using s javadoc link. If the docs are at the class level, I think the class level docs would need to detail which constuctors and methods do and/or do not follow the search behavior. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
