keith-turner commented on a change in pull request #306: ACCUMULO-4170 Clarify 
ClientConfiguration javadocs
URL: https://github.com/apache/accumulo/pull/306#discussion_r144368491
 
 

 ##########
 File path: 
core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java
 ##########
 @@ -41,7 +41,22 @@
 
 /**
  * Contains a list of property keys recognized by the Accumulo client and 
convenience methods for setting them.
- *
+ * <p>
+ * When loading a configuration file from the system, Accumulo uses the 
<em>ACCUMULO_CLIENT_CONF_PATH</em> environment variable,
 
 Review comment:
   >  One for the 1.7 change and another for the 1.8 change and then the 1.8 
change will be merged forward to 2.0?
   
   So you want the changes in 1.8 to be slightly different?  If so it would be 
nice to end up with the following on 1.8 branch.
   
    * Your commit with 1.8 changes
    * Merge commit with your changes from 1.7 
    * Your 1.7 commit
   
   Lets go for the easiest way to get to those changes.  Lets get the changes 
in 1.7 squared away and then we can get the 1.8 changes figured out.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to