keith-turner commented on a change in pull request #321: ACCUMULO-4641 Added loading to cache API URL: https://github.com/apache/accumulo/pull/321#discussion_r150137270
########## File path: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/tinylfu/TinyLfuBlockCache.java ########## @@ -47,7 +47,7 @@ * <li>Cache design: http://highscalability.com/blog/2016/1/25/design-of-a-modern-cache.html</li> * </ul> */ -public final class TinyLfuBlockCache implements BlockCache { +public final class TinyLfuBlockCache extends SynchronousLoadingBlockCache implements BlockCache { Review comment: I am not sure. I saw a comment somewhere that said load operations should be *fast*, which is why I avoided relying on Caffine. I can't remember where I saw that. I am certainly open to refactoring the code to use Caffeine for load synchronization. I tried looking at the internals of Caffine to see where and how it did its load sync, but got lost. Any tips would be appreciated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
