keith-turner commented on a change in pull request #321: ACCUMULO-4641 Added loading to cache API URL: https://github.com/apache/accumulo/pull/321#discussion_r150255263
########## File path: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/tinylfu/TinyLfuBlockCache.java ########## @@ -47,7 +47,7 @@ * <li>Cache design: http://highscalability.com/blog/2016/1/25/design-of-a-modern-cache.html</li> * </ul> */ -public final class TinyLfuBlockCache implements BlockCache { +public final class TinyLfuBlockCache extends SynchronousLoadingBlockCache implements BlockCache { Review comment: Thanks for sharing. That is exactly the type of information I was looking for when spelunking in the Caffeine code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
