keith-turner commented on a change in pull request #347: ACCUMULO-4746 Fluent
API for Mutation
URL: https://github.com/apache/accumulo/pull/347#discussion_r161058495
##########
File path: core/src/test/java/org/apache/accumulo/core/data/MutationTest.java
##########
@@ -183,6 +185,190 @@ private Value nv(String s) {
return new Value(s.getBytes());
}
+ @Test
+ public void testAtFamilyTypes() {
+ final String fam = "f16bc";
+ final String qual = "q1pm2";
+ final String val = "v8672194923750";
+
+ Mutation expected = new Mutation("row5");
+ expected.put(fam, qual, val);
+
+ // Test all family methods, keeping qual and val constant as Strings
+ // fam: byte[]
+ Mutation actual = new Mutation("row5");
+ actual.at().family(fam.getBytes(UTF_8)).qualifier(qual).set(val);
Review comment:
> Less junk in one Java file.
The new interfaces and implementation may not have to be in the the Mutation
file. The only thing that has to be there is the `at()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
