ctubbsii commented on a change in pull request #870: Remove unused code in
master and server
URL: https://github.com/apache/accumulo/pull/870#discussion_r245428548
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
##########
@@ -299,10 +299,6 @@ public boolean isIpBasedRegex() {
return isIpBasedRegex;
}
- public int getMaxConcurrentMigrations() {
Review comment:
It's up to you. We don't make guarantees about these specific
implementations, even if we did have some pseudo-API for the interface, so if
the method isn't on the interface, then it's definitely fine with me for it to
be removed. If it is on the balancer interface itself, I have no strong opinion
about removal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
