ctubbsii commented on a change in pull request #870: Remove unused code in 
master and server
URL: https://github.com/apache/accumulo/pull/870#discussion_r245429155
 
 

 ##########
 File path: 
server/base/src/main/java/org/apache/accumulo/server/security/handler/KerberosAuthenticator.java
 ##########
 @@ -190,9 +188,4 @@ public synchronized boolean userExists(String user) {
     return SUPPORTED_TOKENS;
   }
 
-  @Override
-  public boolean validTokenClass(String tokenClass) {
-    return SUPPORTED_TOKEN_NAMES.contains(tokenClass);
 
 Review comment:
   I'm a bit surprised it wasn't used at all... but since it's on the 
interface, maybe it's best left in place for now, so it doesn't impact 
implementers... at least until we can rethink the whole design of these 
pluggable pieces anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to