ctubbsii commented on issue #1578: Accumulo master hangs after TLS on ZK
URL: https://github.com/apache/accumulo/issues/1578#issuecomment-609924738
 
 
   > > I helped Karthick take a look at this. It seems like SetGoalState is 
using a ServerContext with SingletonReservation.noop(), so maybe that means 
that ZooKeeper is not automatically being closed. Should SetGoalState be using 
a client reservation instead?
   
   @keith-turner is the expert on the reservation stuff. I think most of that 
was done to try to internally manage resources when using Connector vs. the 
more lifecycle-oriented AccumuloClient. I'm not sure how it applies here.
   
   > 
   > I noticed that SetGoalState is the only server utility using ServerContext 
that doesn't have a try-with-resources to automatically call close when 
finished. I think this might be a bug with SetGoalState
   
   That's the kind of thing I was thinking of being at the center of this. I 
don't know if closing `ServerContext` will achieve the desired result, though 
and clean up the ZooKeeper threads.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to