keith-turner edited a comment on issue #1578: Accumulo master hangs after TLS 
on ZK
URL: https://github.com/apache/accumulo/issues/1578#issuecomment-610425219
 
 
   The try-with-resources for the ServerContext will not work because the 
SingletonManager never closes anything for servers currently.  Creating a 
ServerContext puts the SingletonManager in server mode.  One possible solution 
to this is to add a new Mode.CLOSED for SingletonManager.  Then the 
SetGoalState could do something like the following.
   
   ```java
   main() {
     try {
       // current code in main
     } finally {
       // force stop of all singletons and render future attempts to get a 
singleton inoperable.
       SingletonManager.setMode(Mode.CLOSED);
     }
   }
   ```
   
   I think it would also be good to open a zookeeper issue in their Jira.  
While not closing ZK may be an Accumulo issue, I strongly suspect that ZK would 
like all background threads to be daemon threads.  So they may want to know 
they are creating non-deamon threads when using TLS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to