keith-turner commented on a change in pull request #1579: Closes #1576: Update 
importTable with directory list as Set<String>
URL: https://github.com/apache/accumulo/pull/1579#discussion_r404915203
 
 

 ##########
 File path: 
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
 ##########
 @@ -1544,22 +1544,29 @@ public static Path findExportFile(ClientContext 
context, List<String> importDirs
   @Override
   public void importTable(String tableName, String importDir)
       throws TableExistsException, AccumuloException, 
AccumuloSecurityException {
+    importTable(tableName, Set.of(importDir.split(",")));
 
 Review comment:
   Maybe the existing API should maintain its current behavior and only support 
a single dir. This avoids any surprises for existing code.  If someone wants to 
use the new functionality, they need to use the new API.
   ```suggestion
       importTable(tableName, Set.of(importDir));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to