drewfarris commented on a change in pull request #1579: Closes #1576: Update
importTable with directory list as Set<String>
URL: https://github.com/apache/accumulo/pull/1579#discussion_r404990378
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -176,11 +176,27 @@ void create(String tableName, NewTableConfiguration ntc)
*
* @param tableName
* Name of a table to create and import into.
- * @param importDir
- * Directory that contains the files copied by distcp from
exportTable
+ * @param importDirs
+ * A comma-delimited list of directories containing the files
copied by distcp from
+ * exportTable
* @since 1.5.0
+ *
+ * @deprecated since 2.1.0 use {@link #importTable(String, Set)} instead.
+ */
+ @Deprecated
Review comment:
> This does not have to be deprecated because a new method was added.
Hmm, I don't understand why adding a new method eliminates the need for
deprecation. The idea here would be to remove the original `importTable(String,
String)` at some point when it is safe to do so.
Thanks for mentioning the Java 9 parameters. As such, I suspect the right
annotation would be:
```
@Deprecated(since="2.1.0",forRemoval=true)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
