milleruntime commented on a change in pull request #1614:
URL: https://github.com/apache/accumulo/pull/1614#discussion_r428066247
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java
##########
@@ -149,6 +150,11 @@ public void load()
if (mappings.isEmpty())
throw new IllegalArgumentException("Attempted to import zero files
from " + srcPath);
+ long tabletMaxSize = conf.getCount(Property.MASTER_BULK_MAX_TABLETS);
+ if (tabletMaxSize > 0 && mappings.keySet().size() > tabletMaxSize)
Review comment:
I guess the danger with this check is stopping ingest due to false
positives? Like if I have 100 tablets and 10 files going to all tablets could
be normal. I would rather stop 1 file going to all 100 then 10 going to all
100.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
