milleruntime commented on a change in pull request #1614:
URL: https://github.com/apache/accumulo/pull/1614#discussion_r428851706
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java
##########
@@ -576,7 +587,12 @@ private Text toText(byte[] row) {
Thread.currentThread().interrupt();
throw new RuntimeException(e);
} catch (ExecutionException e) {
- throw new RuntimeException(e);
+ // clean up exception for user
+ Throwable t = e.getCause();
+ if (t instanceof IllegalArgumentException) {
+ throw (IllegalArgumentException) t;
+ } else
+ throw new RuntimeException(t);
Review comment:
I thought it was cleaner for the user to just drop the
ExecutionException coming out of the future since that is just implementation
specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
