dlmarion commented on a change in pull request #1677:
URL: https://github.com/apache/accumulo/pull/1677#discussion_r469212023
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReader.java
##########
@@ -38,24 +38,36 @@
public class ZooReader {
private static final Logger log = LoggerFactory.getLogger(ZooReader.class);
- protected static final RetryFactory RETRY_FACTORY =
Retry.builder().maxRetries(10)
+ public static final RetryFactory DEFAULT_RETRY_FACTORY =
Retry.builder().maxRetries(10)
+ .retryAfter(250, MILLISECONDS).incrementBy(250, MILLISECONDS).maxWait(5,
TimeUnit.SECONDS)
+ .backOffFactor(1.5).logInterval(3, TimeUnit.MINUTES).createFactory();
+
+ public static final RetryFactory DISABLED_RETRY_FACTORY =
Retry.builder().maxRetries(0)
.retryAfter(250, MILLISECONDS).incrementBy(250, MILLISECONDS).maxWait(5,
TimeUnit.SECONDS)
.backOffFactor(1.5).logInterval(3, TimeUnit.MINUTES).createFactory();
Review comment:
Looking at the interfaces they are chained together such that they are
needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
