dlmarion commented on a change in pull request #1677:
URL: https://github.com/apache/accumulo/pull/1677#discussion_r469979823
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/ServerContext.java
##########
@@ -68,13 +68,22 @@
private CryptoService cryptoService = null;
public ServerContext(SiteConfiguration siteConfig) {
- this(new ServerInfo(siteConfig));
+ this(new ServerInfo(siteConfig), true);
+ }
+
+ public ServerContext(SiteConfiguration siteConfig, boolean
enableZookeeperRetries) {
+ this(new ServerInfo(siteConfig), enableZookeeperRetries);
}
private ServerContext(ServerInfo info) {
+ this(info, true);
+ }
+
+ private ServerContext(ServerInfo info, boolean enableRetries) {
super(SingletonReservation.noop(), info, info.getSiteConfiguration());
this.info = info;
- zooReaderWriter = new ZooReaderWriter(info.getSiteConfiguration());
+ zooReaderWriter = enableRetries ?
ZooReaderWriter.retriesEnabled(info.getSiteConfiguration())
+ : ZooReaderWriter.retriesDisabled(info.getSiteConfiguration());
Review comment:
> Rather, I think we're suggesting that the implementation of ZooLock
should be changed to distance itself from the general-purpose utilities of
ZooReaderWriter/ZooSession. This can be done by making ZooLock never use those
at all and use something of its own, or as Keith suggested, adding
special-purpose methods on those utilities for ZooLock to safely use.
Understood, I'll work down that path. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
