keith-turner commented on issue #1665: URL: https://github.com/apache/accumulo/issues/1665#issuecomment-673155182
> Rather, my concern is in the difficulty in tracking it down itself, as a result of the current design, as well as potential problems with the overall design of this new configuration parsing stuff for compactions. @ctubbsii the code can easily be found by searching for references to `Property.TSERV_COMPACTION_SERVICE_PREFIX`. The configuration design pattern is not something new, it follows a precedent set by many other Accumulo configuration properties that need to allow a user to configure one or more of something. For other examples see `Property.TABLE_CONSTRAINT_PREFIX`, `Property.TABLE_ITERATOR_PREFIX`, etc. > Instead, these enums seem to exist solely for the documentation generator, and are largely disconnected from the implementation. The defaults under `Property.TSERV_COMPACTION_SERVICE_PREFIX` will be used to create the default compaction services and are not just for documentation. > So, I realize that's a fairly critical view of your code... probably coming across more critical than I intend (sorry, if that's the case). I welcome criticism. You have made this criticism multiple times before. I think it would be more constructive to offer an alternative solution rather than repeatedly criticize this w/o ever offering an alternative. I am not going to spend time thinking about alternatives because I think what is there is fine. If someone else came up with an alternative and I thought it was better, I would be the first to say hey lets ditch the old stuff. I would be happy to meet and discuss this further I will try to connect with you on Slack. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
