ctubbsii commented on issue #1665:
URL: https://github.com/apache/accumulo/issues/1665#issuecomment-673204410


   > The configuration design pattern is not something new, it follows a 
precedent set by many other Accumulo configuration properties 
   
   Okay, I think I see the pattern you were going for now. We actually have two 
kinds of "PREFIX" properties: categorical (like `TABLE_PREFIX`, 
`INSTANCE_PREFIX`, etc.) for logical grouping, and prefacing (like those you 
mentioned, as well as others that look like `*.opts.*` or `*.custom.*`) which 
preface user-defined suffixes. Because these new properties aren't exactly 
categorical, and aren't exactly prefacing, I had difficulty recognizing what 
you were going for. However, I think I get it now. Thanks for the clarification.
   
   As for offering an alternative... it is difficult to think of alternatives 
when one doesn't grasp what is there now. The compaction stuff got added too 
quickly for me to keep up in the past few months. (That's not to say they got 
added too quickly, objectively speaking... just that due to circumstances, I 
hadn't been able to follow it as closely over these last few months as I would 
have needed to in order to understand it fully.) So, I've been stuck at the 
'try-to-understand-what-is-there-now' phase. I believe I now have a better idea 
of what your intent was, and can try to think of alternatives.
   
   I actually have some alternative ideas in mind now, but they aren't concrete 
yet. If I see you in Slack, maybe I can bounce them off you, before they 
coalesce into a future pull request. A preview of what's swirling in my head 
right now: more JSON, fewer separate config properties. Even if I don't see you 
there, I think I have enough understanding now to confidently move forward on 
this ticket, anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to