ctubbsii commented on a change in pull request #239:
URL: https://github.com/apache/accumulo-website/pull/239#discussion_r478485244
##########
File path: contributor/making-release.md
##########
@@ -35,7 +37,7 @@ Before creating a release candidate, all open issues with a
fix version of the r
**TL;DR**
-* `./assemble/build.sh --create-release-candidate` to make the release
candidate
+* `./assemble/build.sh --create-release-candidate -DskipTests -Dspotbugs.skip`
to make the release candidate
Review comment:
This shouldn't be necessary. We can update the release profile to skip
these.
##########
File path: contributor/making-release.md
##########
@@ -19,11 +19,13 @@ Follow these steps to make a release of Apache Accumulo.
There are number of things that are required before attempting to build a
release.
-1. Use gpg-agent, and be sure to increase the gpg-agent cache timeout (via
.gnupg/gpg-agent.conf) to ensure that the agent doesn't require
re-authentication mid-build, as it will cause things to fail. For example, you
can add `default-cache-ttl 6000` to increase the timeout from the default of 10
minutes to over an hour. If you do not have a GPG key, reference the very
thorough [ASF release signing documentation][1].
+1. Use gpg-agent, and be sure to increase the gpg-agent cache timeout (via
.gnupg/gpg-agent.conf) to ensure that the agent doesn't require
re-authentication mid-build, as it will cause things to fail. For example, you
can add `default-cache-ttl 6000` to increase the timeout from the default of 10
minutes to over an hour. If you do not have a GPG key, reference the very
thorough [ASF release signing documentation][1]. Once you are able to sign a
release, add your gpg key to the [KEYS file][keys-file] (instructions are at
the top of the file).
2. Ensure that you're using the correct major release of Java (check javadoc
too).
Review comment:
This line isn't necessary anymore. maven-enforcer-plugin enforces the
java version.
##########
File path: contributor/making-release.md
##########
@@ -19,11 +19,13 @@ Follow these steps to make a release of Apache Accumulo.
There are number of things that are required before attempting to build a
release.
-1. Use gpg-agent, and be sure to increase the gpg-agent cache timeout (via
.gnupg/gpg-agent.conf) to ensure that the agent doesn't require
re-authentication mid-build, as it will cause things to fail. For example, you
can add `default-cache-ttl 6000` to increase the timeout from the default of 10
minutes to over an hour. If you do not have a GPG key, reference the very
thorough [ASF release signing documentation][1].
+1. Use gpg-agent, and be sure to increase the gpg-agent cache timeout (via
.gnupg/gpg-agent.conf) to ensure that the agent doesn't require
re-authentication mid-build, as it will cause things to fail. For example, you
can add `default-cache-ttl 6000` to increase the timeout from the default of 10
minutes to over an hour. If you do not have a GPG key, reference the very
thorough [ASF release signing documentation][1]. Once you are able to sign a
release, add your gpg key to the [KEYS file][keys-file] (instructions are at
the top of the file).
Review comment:
The information about the KEYS file should be a separate bullet point.
##########
File path: contributor/making-release.md
##########
@@ -50,8 +52,7 @@ Before creating a release candidate, all open issues with a
fix version of the r
You should use the provided script assemble/build.sh to create the release
candidate. This script is
desirable as it activates all necessary maven profiles in addition to
verifying that certain preconditions
-are met, like RPM signing availability and the ability to sign files using
GPG. The --test option can
-be used as a dry run for creating a release candidate. The
--create-release-candidate option should be
+are met, like RPM signing availability and the ability to sign files using
GPG. The --create-release-candidate option is
Review comment:
We can drop the information RPM signing info, as we don't build RPMs
anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
