milleruntime commented on a change in pull request #239:
URL: https://github.com/apache/accumulo-website/pull/239#discussion_r478493469
##########
File path: contributor/making-release.md
##########
@@ -35,7 +37,7 @@ Before creating a release candidate, all open issues with a
fix version of the r
**TL;DR**
-* `./assemble/build.sh --create-release-candidate` to make the release
candidate
+* `./assemble/build.sh --create-release-candidate -DskipTests -Dspotbugs.skip`
to make the release candidate
Review comment:
Sounds good. I am confused about the commands after this though and
before the **VOTE**...
```
* `git tag $version $version-rcN` to create an RC tag from the actual tag
* `git tag -d $version` make sure you don't accidentally push a "release" tag
* `git push origin $version-rcN` push the RC tag
* `git checkout -b $version-rcN-branch` save off the branch from the Maven
release plugin
```
Don't we want to wait and tag AFTER the vote is successful?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
