ctubbsii commented on pull request #1653: URL: https://github.com/apache/accumulo/pull/1653#issuecomment-692198061
I spoke with @Manno15 on Slack, and we came to the conclusion that #1616 should be reverted (which I have done) and that this PR can be rebase'd onto main and updated to reflect only the move to Ample to perform the updates (as well as removing any unneeded code that moving to Ample would obsolete, and updating Ample, as needed, to handle differently serialized port numbers and possibly to reuse a batch writer for updating multiple locations, if needed). I don't know if it is necessary to handle the RuntimeExceptions thrown by Ample and rewrapped as DistributedStoreException, or not... especially since Ample itself is written to wrap all checked exceptions and throw them through as RuntimeExceptions. If Ample doesn't think they should be handled, then maybe these stores shouldn't handle them either. I'm leaving that for @Manno15 to investigate further and come to their own conclusion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
