Manno15 commented on a change in pull request #1653:
URL: https://github.com/apache/accumulo/pull/1653#discussion_r488753208
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/metadata/TabletMutatorBase.java
##########
@@ -202,6 +203,23 @@ private String getLocationFamily(LocationType type) {
return this;
}
+ @Override
+ public Ample.TabletMutator putSuspension(Ample.TServer tServer, long
suspensionTime) {
+ Preconditions.checkState(updatesEnabled, "Cannot make updates after
calling mutate.");
+ mutation.put(SuspendLocationColumn.SUSPEND_COLUMN.getColumnFamily(),
+ SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier(),
+ new Value(tServer + "|" + suspensionTime));
Review comment:
Thanks for pointing that out, that was something I didn't notice. I
replaced with ` new Value(tServer.getLocation() + "|" + suspensionTime))` which
more accurately matches `HostAndPort.toString()`. This also solves the issue I
was facing with `MasterRepairsDualAssignmentIT` so I no longer need the if
statement I added in the `HostAndPort` file.
I don't fully understand your second paragraph. Are you suggesting I use the
`SuspendingTServer.fromValue()` function in this mutation instead of doing the
`new Value(tServer.getLocation() + "|" + suspensionTime))`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
