milleruntime commented on a change in pull request #1651:
URL: https://github.com/apache/accumulo/pull/1651#discussion_r516948397
##########
File path:
core/src/main/java/org/apache/accumulo/core/metadata/schema/AmpleImpl.java
##########
@@ -34,12 +70,212 @@ public AmpleImpl(AccumuloClient client) {
@Override
public TabletMetadata readTablet(KeyExtent extent, ColumnType...
colsToFetch) {
- Options builder = TabletsMetadata.builder().forTablet(extent);
+ TabletsMetadata.Options builder =
TabletsMetadata.builder().forTablet(extent);
if (colsToFetch.length > 0)
builder.fetch(colsToFetch);
try (TabletsMetadata tablets = builder.build(client)) {
return Iterables.getOnlyElement(tablets);
Review comment:
A very simple alternative to this change, would be to just have a shared
method return `TabletsMetadata` (before calling getOnlyElement). Is there a
reason just returning `TabletsMetadata` for readTablets() wouldn't suffice?
The method on the interface could look like this:
`public TabletsMetadata readTablets(KeyExtent extent, ColumnType...
colsToFetch)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
