milleruntime commented on a change in pull request #1651:
URL: https://github.com/apache/accumulo/pull/1651#discussion_r526250613
##########
File path:
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java
##########
@@ -79,6 +79,15 @@
private boolean checkConsistency = false;
private boolean saveKeyValues;
private TableId tableId;
+ private AccumuloClient _client;
+
+ Builder(AccumuloClient client) {
+ this._client = client;
+ }
+
+ Builder() {
+
+ }
Review comment:
Should only have one constructor and one build method to prevent coding
errors. Since you have access to the AccumuloClient object at the time you are
calling the method, I think it would be best to go with the
`Builder(AccumuloClient client)` constructor and then end it with the `build()`
method. This will only pass in the client once and prevent it from being null
when calling `build()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
