ctubbsii commented on a change in pull request #1772:
URL: https://github.com/apache/accumulo/pull/1772#discussion_r520911184
##########
File path:
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/table.ftl
##########
@@ -44,7 +44,7 @@
<th title="Key/value pairs over each instance, table or
tablet.">Entries </th>
<th title="The number of Key/Value pairs inserted. (Note that
deletes are considered inserted)">Ingest </th>
<th title="The number of key/value pairs returned to clients.
(Not the number of scans)">Query </th>
- <th title="The amount of time that ingest operations are
suspended while waiting for data to be written to
disk.">Hold Time </th>
+ <th title="The amount of time live ingest (mutations, batch
writer) is suspended while waiting for tserver memory to free up. Writes are
attempting to exceed tserver.memory.maps.max">Hold Time </th>
Review comment:
Reading the docs for that property implies that it's not so simple as
just this property. How, and by which properties, memory is managed, is
complicated and can change over time, as that's implementation.
It might be better to stick to a high-level description, rather than
pointing to specific properties / implementations, and explain that it's simply
being held because its buffers are full and it needs to free up memory by
flushing / minor compacting.
Also, these are just tool-tips, not supposed to be complete docs. I think
"The duration over which commits have been held, waiting for the tserver to
clear up memory."
I have reservations on your wording, because it didn't seem clear to me, and
might be misleading, but I don't know what's best.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
