ctubbsii commented on a change in pull request #1772:
URL: https://github.com/apache/accumulo/pull/1772#discussion_r521077456



##########
File path: 
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/table.ftl
##########
@@ -44,7 +44,7 @@
                 <th title="Key/value pairs over each instance, table or 
tablet.">Entries&nbsp;</th>
                 <th title="The number of Key/Value pairs inserted. (Note that 
deletes are considered inserted)">Ingest&nbsp;</th>
                 <th title="The number of key/value pairs returned to clients. 
(Not the number of scans)">Query&nbsp;</th>
-                <th title="The amount of time that ingest operations are 
suspended while waiting for data to be written to 
disk.">Hold&nbsp;Time&nbsp;</th>
+                <th title="The amount of time live ingest (mutations, batch 
writer) is suspended while waiting for tserver memory to free up. Writes are 
attempting to exceed tserver.memory.maps.max">Hold&nbsp;Time&nbsp;</th>

Review comment:
       Either of those would be fine... I didn't mean to omit the part that 
emphasized live ingest in my suggestion. I only meant to drop the part implying 
that a specific single property was the culprit, from the second sentence.
   
   The only part I thought should be changed for the first sentence is to make 
it "past-tense and ongoing", rather than imply "present tense and 
instantaneous" ("has/have been suspended" vs. "is suspended"). Both of your 
last two suggestions encapsulate what I was going for there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to