ctubbsii commented on pull request #1784: URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728968941
@Manno15 Thanks for this. I saw a new build warning: ``` [WARNING] /home/runner/work/accumulo/accumulo/shell/src/main/java/org/apache/accumulo/shell/Shell.java:[623,13] shutdown() in jline.console.ConsoleReader has been deprecated ``` Presumably, this is because `ConsoleReader` is now `Closeable`. Is that warning something that you can fix? Also, I'm running the full ITs myself, as a double-check, and will run some manual checks in the shell to see if there are any behavioral differences. Also, do you know why the `\t` changes in the tests were necessary? Were we always outputting `\t`, and the console was replacing them with spaces? Also, the original ticket mentioned the following additional things that I'm wondering if they need anything done for them: - [ ] Closing FileReader opened by FileHistory - [ ] The number in "Display all n possibilities?" differs from the actual number of commands listed - [ ] Upgrade to jansi 1.12 - [ ] Default buffer is not printed correctly Some of these are lacking details, so it's not clear what was intended to be done for them, but did you look at any of those to see if those were necessary to address? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
